kou commented on code in PR #39164:
URL: https://github.com/apache/arrow/pull/39164#discussion_r1442633352
##########
cpp/src/arrow/ipc/reader.h:
##########
@@ -317,7 +317,12 @@ class ARROW_EXPORT Listener {
/// \since 0.17.0
class ARROW_EXPORT CollectListener : public Listener {
public:
- CollectListener() : schema_(), filtered_schema_(), record_batches_(),
metadatas_() {}
+ explicit CollectListener(bool copy_record_batch = false)
Review Comment:
I reverted this change add a create new `CopyCollectListener()` only for
test because I'm not sure whether this API is good or not.
We can defer the API change decision by this because this doesn't change
public APi. We can reconsider public API later if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
