eddelbuettel opened a new issue, #354:
URL: https://github.com/apache/arrow-nanoarrow/issues/354
I see
```c
nanoarrow/nanoarrow_testing.hpp: In member function ‘ArrowErrorCode
nanoarrow::testing::TestingJSONWriter::WriteType(std::ostream&, const
ArrowSchemaView*)’:
nanoarrow/nanoarrow_testing.hpp:351:15: warning: variable ‘type’ set but not
used [-Wunused-but-set-variable]
351 | ArrowType type;
|
```
and in
```c
ArrowErrorCode WriteType(std::ostream& out, const ArrowSchemaView* field) {
ArrowType type;
if (field->extension_name.data != nullptr) {
type = field->storage_type;
} else {
type = field->type;
}
out << "{";
switch (field->type) {
// [...]
```
`type` is never used. Did you mean to switch on `type`, not `field->type` ?
If not the six lines at the top can probably go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
