matthewgapp commented on code in PR #7581:
URL: https://github.com/apache/arrow-datafusion/pull/7581#discussion_r1445673374
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1311,6 +1335,35 @@ impl DefaultPhysicalPlanner {
Ok(plan)
}
}
+ // LogicalPlan::SubqueryAlias(SubqueryAlias())
+ LogicalPlan::RecursiveQuery(RecursiveQuery { name,
static_term, recursive_term, is_distinct }) => {
Review Comment:
the weirdest thing is happening. I'm getting the following test error that
is reproducible on my branch but not on main.
```
thread 'tpcds_physical_q54' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`
Caused by:
process didn't exit successfully:
`/Users/matthewgapp/code/forked/arrow-datafusion/target/debug/deps/tpcds_planning-25376fe0cc16d297`
(signal: 6, SIGABRT: process abort signal)
```
Commenting out these branches and replacing with a
```rust
_ => panic!("test")
```
results in the test passing. Moreover, keeping these branches,
`RecursiveQuery` and `NamedRelation` and instead just plopping in a panic
statement within them, causes the test to pass too. Extremely strange given the
test never reaches these paths because it's not a recursive query. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
