metesynnada opened a new pull request, #8802:
URL: https://github.com/apache/arrow-datafusion/pull/8802

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   ## Rationale for this change
   
   
   > In general, issuing a blocking call or performing a lot of compute in a 
future without yielding is problematic, as it may prevent the executor from 
driving other futures forward.
   
   https://docs.rs/tokio/latest/tokio/task/fn.spawn_blocking.html
   
   Previously, the serialization process was always asynchronous, even if there 
were no asynchronous calls involved, which was a CPU-bound operation. This is 
an anti-pattern.
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Make `BatchSerializer` sync, and use it with `tokio::task::spawn_blocking`.
   
   ## Are these changes tested?
   
   With existing tests.
   
   ## Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to