tshauck opened a new issue, #8808:
URL: https://github.com/apache/arrow-datafusion/issues/8808
Hi,
Working a bit with the CLI code, I noticed the arguments to the various
`exec_from_*` functions are a little inconsistent, so I'm proposing updating
these functions to standardize them.
Right now, there's:
```rust
// order: context, exec source, print options
pub async fn exec_from_lines(
ctx: &mut SessionContext,
reader: &mut BufReader<File>,
print_options: &PrintOptions,
)
```
```rust
// order: exec source, context, print options
pub async fn exec_from_files(
files: Vec<String>,
ctx: &mut SessionContext,
print_options: &PrintOptions,
)
```
```rust
// order: context, print options
pub async fn exec_from_repl(
ctx: &mut SessionContext,
print_options: &mut PrintOptions,
)
```
```rust
// order: context, print options, exec source
pub async fn exec_from_commands(
ctx: &mut SessionContext,
print_options: &PrintOptions,
commands: Vec<String>,
)
```
If minor, it seems like it'd be nice to have these inline. I'll open up a PR
to standardize on `order: context, (source), print options`, but I'm happy to
go a different route and/or have the PR closed.
Thanks,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
