raulcd commented on code in PR #39516:
URL: https://github.com/apache/arrow/pull/39516#discussion_r1447218502
##########
python/pyarrow/array.pxi:
##########
@@ -2467,7 +2467,7 @@ cdef class MapArray(ListArray):
"""
@staticmethod
- def from_arrays(offsets, keys, items, MemoryPool pool=None):
+ def from_arrays(offsets, keys, items, DataType type=None, MemoryPool
pool=None):
Review Comment:
is there a reason to use `type` as a variable name? `type` is [a built-in
function in Python](https://docs.python.org/3/library/functions.html#type) and
unless necessary could we call it `datatype` or `data_type`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
