my-vegetable-has-exploded commented on code in PR #8810: URL: https://github.com/apache/arrow-datafusion/pull/8810#discussion_r1448224053
########## pre-commit.sh: ########## @@ -60,7 +60,7 @@ echo -e "$(GREEN INFO): cargo clippy ..." # Cargo clippy always return exit code 0, and `tee` doesn't work. # So let's just run cargo clippy. -cargo clippy +cargo clippy --all-targets --workspace --features avro,pyarrow -- -D warnings Review Comment: I tried to just use `source ./ci/scripts/rust_clippy.sh` here, but with `set -ex` in it, the process would terminate if clippy is not happy which causes subsequent `fmt` won't execute. So I copy the whole cargo command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
