kou commented on code in PR #39081: URL: https://github.com/apache/arrow/pull/39081#discussion_r1448450404
########## http/examples/get/client.cpp: ########## Review Comment: It should be crashed. But it's not crashed on my environment. (I try this now.) It seems that this usage is safe. FYI: https://github.com/apache/arrow/blob/30c4e157a920981a853352ea2c24473496c7e595/cpp/src/arrow/ipc/message.cc#L647 doesn't copy the given data (`contents` for `WriteFunction()`). So a decoded record batch that refers the given data is invalid when the given data is invalid. I think that curl invalidates the given data immediately after `WriteFunction()` call but it seems that the given data is still valid after `curl_easy_perform()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
