paleolimbot commented on code in PR #1453:
URL: https://github.com/apache/arrow-adbc/pull/1453#discussion_r1449122082
##########
r/adbcdrivermanager/src/driver_base.h:
##########
@@ -266,7 +266,9 @@ class ObjectBase {
AdbcStatusCode CSetOptionBytes(const char* key, const uint8_t* value, size_t
length,
AdbcError* error) {
- std::basic_string<uint8_t> cppvalue(value, length);
+ std::vector<uint8_t> cppvalue(length);
+ memcpy(cppvalue.data(), value, length);
Review Comment:
That is way better (thank you!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
