matthewgapp commented on code in PR #7581:
URL: https://github.com/apache/arrow-datafusion/pull/7581#discussion_r1449537689
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -112,6 +112,8 @@ pub enum LogicalPlan {
/// produces 0 or 1 row. This is used to implement SQL `SELECT`
/// that has no values in the `FROM` clause.
EmptyRelation(EmptyRelation),
+ /// A named temporary relation with a schema.
+ NamedRelation(NamedRelation),
Review Comment:
Wow, tyty! I was in the process of implementing the shared table and my
implementation turned out very similar to yours although I ended up working
around the crate dependency graph constraints a bit differently by introducing
a couple new traits. But I did end up exposing a method on the context to
generate a table. I like your approach better.
I tested out your poc and performance remains about the same between my
previous implementation and your new worktable approach! (which makes sense).
I'm going to go ahead and work based on your POC toward the list of PRs that
Andrew wants to get this landed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
