nealrichardson commented on PR #39602: URL: https://github.com/apache/arrow/pull/39602#issuecomment-1892711063
It looks like we have some growing confusion in our env vars that govern the build script. [The docker-compose job has these set](https://github.com/apache/arrow/blob/main/docker-compose.yml#L1416-L1417 ): ``` FORCE_BUNDLED_BUILD: 'true' LIBARROW_BUILD: 'true' ``` `FORCE_BUNDLED_BUILD` is only used in the `configure` script to skip looking for libarrow on the system. With the current state of `configure`, it's basically equivalent to `ARROW_USE_PKG_CONFIG=false`, assuming `ARROW_HOME` is not set. It doesn't trigger a source build. `LIBARROW_BUILD` is only checked to see if it is `false`, to prevent doing the bundled source build. The nixlibs.R script does not check for `true` to mean that you *must* do a source build, i.e. skip binary downloading. Side note: I agree with the comment in https://github.com/apache/arrow/pull/38534/files#r1387468097 that `LIBARROW_BINARY=false` should be what we recommend (and in fact already document in the script) for saying not to download a prebuilt library. `LIBARROW_DOWNLOAD` existed before but was removed, though reading that discussion, apparently a no-op artifact of that was not cleaned up, which caused some confusion. This feels like creeping scope so perhaps I should make another issue, but IMO: * `FORCE_BUNDLED_BUILD` should be deprecated in favor of `LIBARROW_BUILD`. I don't think we recommend it to people, it's more for our testing. * `LIBARROW_BUILD=true` is equivalent to `LIBARROW_BINARY=false`. If `LIBARROW_BUILD=true` and `LIBARROW_BINARY` is something other than unset or `false`, raise an error. * Set `download_libarrow_ok` based on `LIBARROW_BINARY=false, not `LIBARROW_DOWNLOAD`. Remove references to `LIBARROW_DOWNLOAD`. * If we want something explicit about preventing downloading, that's `TEST_OFFLINE_BUILD` currently; if that's a feature we want to advertise, we could rename that something that's not `TEST_`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
