viirya commented on code in PR #8878:
URL: https://github.com/apache/arrow-datafusion/pull/8878#discussion_r1452803219
##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -191,9 +191,11 @@ pub(crate) enum Hint {
AcceptsSingular,
}
-/// decorates a function to handle [`ScalarValue`]s by converting them to
arrays before calling the function
+/// Decorates a function to handle [`ScalarValue`]s by converting them to
arrays before calling the function
/// and vice-versa after evaluation.
-pub fn make_scalar_function<F>(inner: F) -> ScalarFunctionImplementation
+/// Note that this function makes a scalar function with no arguments or all
scalar inputs return a scalar.
+/// That's said its output will be same for all input rows in a batch.
+pub(crate) fn make_scalar_function<F>(inner: F) -> ScalarFunctionImplementation
Review Comment:
Or we should deprecate it and ask user to use `ScalarUDFImpl` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
