berkaysynnada commented on PR #8891: URL: https://github.com/apache/arrow-datafusion/pull/8891#issuecomment-1895928350
> I'm not sure I get this part. The docstring you have updated for `transform()` states that the order is: ``` 1) f_down(ParentNode) 2) f_down(ChildNode1) 3) f_up(ChildNode1) 4) f_down(ChildNode2) 5) f_up(ChildNode2) 6) f_up(ParentNode) ``` I believe this is not fully correct, and it works in that order now: ``` 1) f_down(ParentNode) 2) f_down(ChildNode1) 3) f_down(ChildNode2) 4) f_up(ChildNode1) 5) f_up(ChildNode2) 6) f_up(ParentNode) ``` I meant what if we intend to do such: ``` 1) f_up(ChildNode1) 2) f_up(ChildNode2) 3) f_up(ParentNode) 4) f_down(ParentNode) 5) f_down(ChildNode1) 6) f_down(ChildNode2) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
