vibhatha commented on code in PR #39529:
URL: https://github.com/apache/arrow/pull/39529#discussion_r1456844308
##########
java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDictionaryUtils.java:
##########
@@ -78,7 +79,7 @@ public void testCreateSchema() {
Schema newSchema = DictionaryUtils.generateSchema(schema, dictProvider,
dictionaryUsed);
// assert that a new schema is created.
- assertTrue(schema != newSchema);
+ assertNotEquals(schema, newSchema);
Review Comment:
Just curious, if we use assertNotSame, it would mean that it is not the same
object in memory. But in this case, I thought we are merely checking the status
of the created objects. Please correct me if I am wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
