pitrou commented on PR #39701: URL: https://github.com/apache/arrow/pull/39701#issuecomment-1900118900
Did you run some benchmarks? You can't claim something improves performance without measuring it. `std::inplace_merge` does not avoid a memory allocation, it just allocates the memory implicitly. Quoting the [documentation](https://en.cppreference.com/w/cpp/algorithm/inplace_merge): > This function attempts to allocate a temporary buffer. If the allocation fails, the less efficient algorithm is chosen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
