paleolimbot commented on code in PR #367:
URL: https://github.com/apache/arrow-nanoarrow/pull/367#discussion_r1459315877
##########
src/nanoarrow/nanoarrow_types.h:
##########
@@ -443,7 +443,9 @@ enum ArrowType {
NANOARROW_TYPE_LARGE_STRING,
NANOARROW_TYPE_LARGE_BINARY,
NANOARROW_TYPE_LARGE_LIST,
- NANOARROW_TYPE_INTERVAL_MONTH_DAY_NANO
+ NANOARROW_TYPE_INTERVAL_MONTH_DAY_NANO,
+ NANOARROW_TYPE_BINARY_VIEW,
+ NANOARROW_TYPE_STRING_VIEW,
Review Comment:
I think it's probably best to put it at the end to keep the existing values
(we can always rearrange them in places where they're more likely to be seen).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
