tustvold commented on code in PR #8908:
URL: https://github.com/apache/arrow-datafusion/pull/8908#discussion_r1460633119
##########
datafusion/expr/src/expr.rs:
##########
@@ -1869,10 +1869,14 @@ mod test {
let exp2 = col("a") + lit(2);
let exp3 = !(col("a") + lit(2));
- assert!(exp1 < exp2);
- assert!(exp2 > exp1);
- assert!(exp2 > exp3);
- assert!(exp3 < exp2);
+ // Since comparisons are done using hash value of the expression
Review Comment:
Ahash is not a stable hash algorithm and may not only change between
platforms, but also minor releases. I lack context into why we are ordering
based on hashes, but my initial response is this is probably incorrect,
especially if it is inconsistent with the equality relation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
