alamb commented on code in PR #8849:
URL: https://github.com/apache/arrow-datafusion/pull/8849#discussion_r1460843480
##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -152,6 +155,8 @@ impl AggregateExpr for DistinctCount {
Float32 => float_distinct_count_accumulator!(Float32Type),
Float64 => float_distinct_count_accumulator!(Float64Type),
+ Utf8 => Ok(Box::new(StringDistinctCountAccumulator::new())),
Review Comment:
Update here is that we used `insert_accounted` -- that is not well
documented but I think it is the correct API
We just need to write some tests to ensure the accounting is reasonable
(like adding strings makes the memory accounting go up, and adding the same
strings over and over does not)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
