mustafasrepo commented on PR #8920: URL: https://github.com/apache/arrow-datafusion/pull/8920#issuecomment-1903489969
I think this PR add two functionality. Which are - Removing hard coded output types from builtin window functions so that all handled using `return_type` API. - Removing `physical_input_schema` from `create_window_expr` function. I think first change is better. However, second change is misleading. With the changes in this PR, given `logical_input_schema` is no longer actual input schema, but really window schema. However, I think we can merge this PR as is, Then I will file a PR to retract 2nd part. We can discuss pros and cons of it in that PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
