kou commented on code in PR #39750:
URL: https://github.com/apache/arrow/pull/39750#discussion_r1464031189
##########
dev/release/utils-prepare.sh:
##########
@@ -139,6 +140,12 @@ update_versions() {
fi
rm -f NEWS.md.bak
git add NEWS.md
+
+ find . -name "_pkgdown.yml" -exec sed -i.bak -E -e \
+ "s|(github\\.com/apache/arrow/go)/v[0-9]+|\1/v${major_version}|g" {} \;
Review Comment:
We don't need to use `find` here:
```suggestion
sed -i.bak -E -e \
"s|(github\\.com/apache/arrow/go)/v[0-9]+|\1/v${major_version}|g" \
_pkgdown.yml
```
##########
dev/release/utils-prepare.sh:
##########
@@ -164,6 +171,15 @@ update_versions() {
git add .
popd
+ pushd "${ARROW_DIR}/docs/source"
+ # godoc link must reference current version, will reference v0.0.0 (2018)
otherwise
+ find . -name "index.rst" -exec sed -i.bak -E -e \
+ "s|(github\\.com/apache/arrow/go)/v[0-9]+|\1/v${major_version}|g" {} \;
+
+ rm -f index.rst.bak
Review Comment:
ditto.
##########
dev/release/utils-prepare.sh:
##########
@@ -164,6 +171,15 @@ update_versions() {
git add .
popd
+ pushd "${ARROW_DIR}/docs/source"
+ # godoc link must reference current version, will reference v0.0.0 (2018)
otherwise
Review Comment:
Could you add this comment to the `r/_pkgdown.yml` part too?
##########
dev/release/utils-prepare.sh:
##########
@@ -139,6 +140,12 @@ update_versions() {
fi
rm -f NEWS.md.bak
git add NEWS.md
+
+ find . -name "_pkgdown.yml" -exec sed -i.bak -E -e \
+ "s|(github\\.com/apache/arrow/go)/v[0-9]+|\1/v${major_version}|g" {} \;
+
Review Comment:
Could you remove this empty line because the above `sed` and this `rm` are
related?
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
