ianmcook commented on a change in pull request #9287:
URL: https://github.com/apache/arrow/pull/9287#discussion_r565769598
##########
File path: cpp/vcpkg.json
##########
@@ -0,0 +1,40 @@
+{
+ "name": "arrow",
+ "version-string": "4.0.0-SNAPSHOT",
+ "dependencies": [
+ "abseil",
+ {
+ "name": "aws-sdk-cpp",
+ "features": [
+ "config",
+ "cognito-identity",
+ "identity-management",
+ "s3",
+ "sts",
+ "transfer"
+ ]
+ },
+ "benchmark",
Review comment:
The larger purpose of adding this `vcpkg.json` manifest file is to
improve the experience for Windows-based Arrow C++ developers who prefer vcpkg
over conda ([ARROW-11336](https://issues.apache.org/jira/browse/ARROW-11336)).
We want to give Windows devs two alternative ways to get the same build
dependencies: vcpkg or conda. Therefore I want to keep what's here as similar
as possible to what's in
[ci/conda_env_cpp.yml](https://github.com/apache/arrow/blob/master/ci/conda_env_cpp.yml),
which is what we [tell Windows devs to use with
conda](https://arrow.apache.org/docs/developers/cpp/windows.html#using-conda-forge-for-build-dependencies).
That contains benchmark and gtest, so I think this should too. That way all
the latter instructions can be consistent regardless of whether vcpkg or conda
was used.
P.S. I can provide the mapping of each conda-forge package to the analogous
vcpkg package if you'd like to see that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
