viirya commented on PR #1:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/1#issuecomment-1913367405
I manually run the script with PR.
```
NOT APPROVED: .gitignore (./.gitignore): false
NOT APPROVED: Makefile (./Makefile): false
NOT APPROVED: filtered_rat.txt (./filtered_rat.txt): false
NOT APPROVED: rat.txt (./rat.txt): false
NOT APPROVED: rat_exclude_files.txt (./rat_exclude_files.txt): false
NOT APPROVED: rust-toolchain (./rust-toolchain): false
NOT APPROVED: core/.lldbinit (./core/.lldbinit): false
NOT APPROVED: core/Cargo.lock (./core/Cargo.lock): false
NOT APPROVED: spark/src/test/resources/tpch-extended/q1.sql
(./spark/src/test/resources/tpch-extended/q1.sql): false
9 unapproved licences. Check rat report: rat.txt
```
filtered_rat.txt, rat.txt, rat_exclude_files.txt are the files related to
the RAT check script.
q1.sql is SQL test query file. In DataFusion, these files don't have license
header too.
Cargo.lock is automatically generated by Cargo.
I think core/.lldbinit is committed wrongly. It is not necessary. Removed it.
Only missing license header is Makefile. I just added it.
Except for the script related files (filtered_rat.txt, rat.txt,
rat_exclude_files.txt), q1
I don't see any source codes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
