av8or1 opened a new pull request, #39840:
URL: https://github.com/apache/arrow/pull/39840
Modifications to support the deletion of a file.
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
To support the deletion of files on Azure.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Resolution of the conflict in ~cpp/src/arrow/filesystem/azurefs_test.cc.
Here are my original comments regarding this modification in the abstract:
Modified:
~cpp/src/arrow/filesystem/azurerefs.cc
~cpp/src/arrow/filesystem/azurerefs_test.cc
These modifications implement the method and provide regression testing,
respectively.
I have also incorporated feedback from felipecrv, which resulted in an
updated version of the DeleteFile() method. I also figured out why kou was
mentioning an extraneous azurefs_test.cc being included in the top level of the
repo. I have ensured that this didn't occur again with this PR. Apologies to
kou.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
I tested the modification by creating a file via the web browser on our
internal ADLS, then ran a sample program that deleted the file. I added three
regression tests to cover the use case scenarios of:
A valid delete attempt, where "valid" means that the file exists and is
indeed a file
An intentional failure where a file delete is attempted, but the file does
not exist
An intentional failure where a file delete is attempted, but the target is
not a file
Regarding the modifications to the regression suite... I don't know how to
run the Arrow regression. Need instructions. The original code in
~cpp/src/arrow/filesystem/azurefs.cc is tested, as previously mentioned in
https://github.com/apache/arrow/pull/39648.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Overall, this code includes a new method to delete a file on an Azure
server. That is likely something that will need inclusion in the documentation,
but as this is my first PR, I can't say how things are usually done with the
Arrow project.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line
below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid
data to be produced, or (c) a bug that causes a crash (even when the API
contract is upheld). We use this to highlight fixes to issues that may affect
users without their knowledge. For this reason, fixing bugs that cause errors
don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
