alamb commented on PR #9050:
URL: 
https://github.com/apache/arrow-datafusion/pull/9050#issuecomment-1915694810

   Here are the results of running the planning benchmark:
   
   Command:
   ```shell
   cargo bench --bench sql_planner
   ```
   
   I compared to 92104a54469c8401b799fb3fa855f3f1cb9d8745
   
   Results show a small but positive improvement (0 - 3%) ✅ 
   
   ```
   logical_select_one_from_700
                           time:   [2.1687 ms 2.1705 ms 2.1725 ms]
                           change: [-1.1189% -0.9112% -0.7395%] (p = 0.00 < 
0.05)
                           Change within noise threshold.
   Found 4 outliers among 100 measurements (4.00%)
     1 (1.00%) low mild
     1 (1.00%) high mild
     2 (2.00%) high severe
   
   physical_select_one_from_700
                           time:   [17.260 ms 17.280 ms 17.308 ms]
                           change: [+0.0368% +0.1677% +0.3832%] (p = 0.02 < 
0.05)
                           Change within noise threshold.
   Found 6 outliers among 100 measurements (6.00%)
     2 (2.00%) high mild
     4 (4.00%) high severe
   
   Benchmarking logical_trivial_join_low_numbered_columns: Warming up for 
3.0000 s
   Warning: Unable to complete 100 samples in 5.0s. You may wish to increase 
target time to 5.3s, enable flat sampling, or reduce sample count to 60.
   logical_trivial_join_low_numbered_columns
                           time:   [1.0610 ms 1.0630 ms 1.0651 ms]
                           change: [-0.3738% -0.0743% +0.2045%] (p = 0.61 > 
0.05)
                           No change in performance detected.
   Found 4 outliers among 100 measurements (4.00%)
     2 (2.00%) high mild
     2 (2.00%) high severe
   
   Benchmarking logical_trivial_join_high_numbered_columns: Warming up for 
3.0000 s
   Warning: Unable to complete 100 samples in 5.0s. You may wish to increase 
target time to 5.5s, enable flat sampling, or reduce sample count to 60.
   logical_trivial_join_high_numbered_columns
                           time:   [1.0949 ms 1.0966 ms 1.0984 ms]
                           change: [-1.5726% -0.8182% -0.3244%] (p = 0.01 < 
0.05)
                           Change within noise threshold.
   Found 3 outliers among 100 measurements (3.00%)
     1 (1.00%) high mild
     2 (2.00%) high severe
   
   Benchmarking logical_aggregate_with_join: Warming up for 3.0000 s
   Warning: Unable to complete 100 samples in 5.0s. You may wish to increase 
target time to 7.9s, enable flat sampling, or reduce sample count to 50.
   logical_aggregate_with_join
                           time:   [1.5551 ms 1.5570 ms 1.5592 ms]
                           change: [-0.6869% -0.4593% -0.2266%] (p = 0.00 < 
0.05)
                           Change within noise threshold.
   Found 5 outliers among 100 measurements (5.00%)
     1 (1.00%) low mild
     3 (3.00%) high mild
     1 (1.00%) high severe
   
   physical_plan_tpch      time:   [4.6632 ms 4.6695 ms 4.6766 ms]
                           change: [-3.8696% -3.4432% -3.1385%] (p = 0.00 < 
0.05)
                           Performance has improved.
   Found 10 outliers among 100 measurements (10.00%)
     7 (7.00%) high mild
     3 (3.00%) high severe
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to