jorisvandenbossche commented on code in PR #39850:
URL: https://github.com/apache/arrow/pull/39850#discussion_r1471013425
##########
python/pyarrow/tests/test_ipc.py:
##########
@@ -590,7 +590,8 @@ def test_read_options_included_fields(stream_fixture):
assert result1 == table
-def test_dictionary_delta(format_fixture):
+def test_dictionary_delta(format_fixture, request):
+ format_fixture = request.getfixturevalue(format_fixture)
Review Comment:
I would move it here to the format_fixture as well, just to keep it as close
to the definition
##########
python/pyarrow/tests/test_fs.py:
##########
@@ -419,22 +419,26 @@ def filesystem_config(request):
@pytest.fixture
-def fs(request, filesystem_config):
+def fs(filesystem_config, request):
+ filesystem_config = request.getfixturevalue(filesystem_config)
Review Comment:
Move this to the filesystem_config fixture just above?
##########
python/pyarrow/tests/test_dataset.py:
##########
@@ -100,7 +100,6 @@ def assert_dataset_fragment_convenience_methods(dataset):
@pytest.fixture
[email protected]
Review Comment:
Do we need to keep this? (it does use parquet)
##########
python/pyarrow/tests/test_dataset.py:
##########
@@ -1342,7 +1340,8 @@ def test_fragments_parquet_row_groups_dictionary(tempdir,
dataset_reader):
@pytest.mark.parquet
-def test_fragments_parquet_ensure_metadata(tempdir, open_logging_fs,
pickle_module):
+def test_fragments_parquet_ensure_metadata(tempdir, open_logging_fs,
+ pickle_module):
Review Comment:
You can maybe undo those (now formatting-only) changes to reduce the diff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
