alamb commented on PR #9015: URL: https://github.com/apache/arrow-datafusion/pull/9015#issuecomment-1920114904
Benchmark results (I don't really see any noticeable change). Not sure why it looks like this branch is faster in some cases. I'll rerun to double check ``` -------------------- Benchmark tpch_mem.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ df-mem-pool_6934_debug-dump-memory-pool ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 209.82ms │ 208.29ms │ no change │ │ QQuery 2 │ 42.70ms │ 43.69ms │ no change │ │ QQuery 3 │ 76.14ms │ 76.32ms │ no change │ │ QQuery 4 │ 74.19ms │ 73.08ms │ no change │ │ QQuery 5 │ 120.29ms │ 118.37ms │ no change │ │ QQuery 6 │ 16.58ms │ 15.76ms │ no change │ │ QQuery 7 │ 310.74ms │ 300.37ms │ no change │ │ QQuery 8 │ 74.19ms │ 74.38ms │ no change │ │ QQuery 9 │ 124.90ms │ 123.22ms │ no change │ │ QQuery 10 │ 150.40ms │ 147.62ms │ no change │ │ QQuery 11 │ 34.56ms │ 34.43ms │ no change │ │ QQuery 12 │ 66.94ms │ 64.90ms │ no change │ │ QQuery 13 │ 83.11ms │ 84.24ms │ no change │ │ QQuery 14 │ 24.58ms │ 24.65ms │ no change │ │ QQuery 15 │ 55.08ms │ 54.35ms │ no change │ │ QQuery 16 │ 45.64ms │ 45.04ms │ no change │ │ QQuery 17 │ 169.01ms │ 158.65ms │ +1.07x faster │ │ QQuery 18 │ 462.15ms │ 448.99ms │ no change │ │ QQuery 19 │ 63.04ms │ 58.88ms │ +1.07x faster │ │ QQuery 20 │ 114.51ms │ 113.25ms │ no change │ │ QQuery 21 │ 350.09ms │ 344.54ms │ no change │ │ QQuery 22 │ 31.29ms │ 29.17ms │ +1.07x faster │ └──────────────┴───────────┴─────────────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main_base) │ 2699.94ms │ │ Total Time (df-mem-pool_6934_debug-dump-memory-pool) │ 2642.17ms │ │ Average Time (main_base) │ 122.72ms │ │ Average Time (df-mem-pool_6934_debug-dump-memory-pool) │ 120.10ms │ │ Queries Faster │ 3 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 19 │ └────────────────────────────────────────────────────────┴───────────┘ ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ df-mem-pool_6934_debug-dump-memory-pool ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 0.90ms │ 0.93ms │ no change │ │ QQuery 1 │ 91.92ms │ 86.94ms │ +1.06x faster │ │ QQuery 2 │ 193.55ms │ 192.43ms │ no change │ │ QQuery 3 │ 202.04ms │ 194.44ms │ no change │ │ QQuery 4 │ 2035.67ms │ 2064.17ms │ no change │ │ QQuery 5 │ 2634.69ms │ 2710.60ms │ no change │ │ QQuery 6 │ 80.50ms │ 83.28ms │ no change │ │ QQuery 7 │ 96.91ms │ 91.12ms │ +1.06x faster │ │ QQuery 8 │ 3141.36ms │ 3072.50ms │ no change │ │ QQuery 9 │ 2238.23ms │ 2249.01ms │ no change │ │ QQuery 10 │ 778.65ms │ 805.28ms │ no change │ │ QQuery 11 │ 851.89ms │ 892.85ms │ no change │ │ QQuery 12 │ 2480.74ms │ 2476.18ms │ no change │ │ QQuery 13 │ 4782.56ms │ 4655.77ms │ no change │ │ QQuery 14 │ 2708.77ms │ 2730.93ms │ no change │ │ QQuery 15 │ 2265.00ms │ 2311.53ms │ no change │ │ QQuery 16 │ 5628.48ms │ 5469.02ms │ no change │ │ QQuery 17 │ 5499.17ms │ 5365.51ms │ no change │ │ QQuery 18 │ 11546.73ms │ 11089.49ms │ no change │ │ QQuery 19 │ 160.21ms │ 156.05ms │ no change │ │ QQuery 20 │ 2627.86ms │ 2683.35ms │ no change │ │ QQuery 21 │ 3367.59ms │ 3493.11ms │ no change │ │ QQuery 22 │ 9249.51ms │ 9366.63ms │ no change │ │ QQuery 23 │ 21063.00ms │ 21867.58ms │ no change │ │ QQuery 24 │ 1325.68ms │ 1395.85ms │ 1.05x slower │ │ QQuery 25 │ 1149.54ms │ 1184.26ms │ no change │ │ QQuery 26 │ 1461.56ms │ 1491.37ms │ no change │ │ QQuery 27 │ 3855.43ms │ 3903.53ms │ no change │ │ QQuery 28 │ 30624.92ms │ 27627.27ms │ +1.11x faster │ │ QQuery 29 │ 1061.67ms │ 1031.11ms │ no change │ │ QQuery 30 │ 2473.21ms │ 2359.27ms │ no change │ │ QQuery 31 │ 3170.14ms │ 3067.15ms │ no change │ │ QQuery 32 │ 16379.80ms │ 15484.19ms │ +1.06x faster │ │ QQuery 33 │ 12534.18ms │ 11905.42ms │ +1.05x faster │ │ QQuery 34 │ 13092.84ms │ 12631.76ms │ no change │ │ QQuery 35 │ 3839.99ms │ 3575.27ms │ +1.07x faster │ │ QQuery 36 │ 414.06ms │ 434.18ms │ no change │ │ QQuery 37 │ 253.10ms │ 245.90ms │ no change │ │ QQuery 38 │ 195.16ms │ 191.95ms │ no change │ │ QQuery 39 │ 1094.19ms │ 1051.57ms │ no change │ │ QQuery 40 │ 84.61ms │ 86.44ms │ no change │ │ QQuery 41 │ 81.51ms │ 79.40ms │ no change │ │ QQuery 42 │ 89.56ms │ 89.58ms │ no change │ └──────────────┴────────────┴─────────────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩ │ Total Time (main_base) │ 176907.09ms │ │ Total Time (df-mem-pool_6934_debug-dump-memory-pool) │ 171944.20ms │ │ Average Time (main_base) │ 4114.12ms │ │ Average Time (df-mem-pool_6934_debug-dump-memory-pool) │ 3998.70ms │ │ Queries Faster │ 6 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 36 │ └────────────────────────────────────────────────────────┴─────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
