adamreeve commented on code in PR #39871:
URL: https://github.com/apache/arrow/pull/39871#discussion_r1473645448
##########
csharp/src/Apache.Arrow/Ipc/IpcOptions.cs:
##########
@@ -25,6 +25,23 @@ public class IpcOptions
/// </summary>
public bool WriteLegacyIpcFormat { get; set; }
+ /// <summary>
+ /// The compression codec to use to compress data buffers.
+ /// If null (the default value), no compression is used.
+ /// </summary>
+ public CompressionCodecType? CompressionCodec { get; set; }
+
+ /// <summary>
+ /// The compression codec factory used to create compression codecs.
+ /// Must be provided if a CompressionCodec is specified.
+ /// </summary>
+ public ICompressionCodecFactory CompressionCodecFactory { get; set; }
Review Comment:
I'm not sure whether the factory should be included in the options or
whether it makes more sense to be passed to the writer constructor. It's nice
to have here to avoid complicating the constructor too much, and because it
goes together with the codec option, but I don't know if it should really be
considered an "option".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
