paleolimbot commented on code in PR #378:
URL: https://github.com/apache/arrow-nanoarrow/pull/378#discussion_r1474693375
##########
python/src/nanoarrow/_lib.pyx:
##########
@@ -1024,23 +1076,24 @@ cdef class CBufferView:
this buffer content does not apply any parent offset.
"""
cdef object _base
- cdef ArrowBufferView* _ptr
+ cdef ArrowBufferView _ptr
cdef ArrowBufferType _buffer_type
cdef ArrowType _buffer_data_type
- cdef ArrowDevice* _device
+ cdef CDevice _device
cdef Py_ssize_t _element_size_bits
cdef Py_ssize_t _shape
cdef Py_ssize_t _strides
cdef char _format[128]
- def __cinit__(self, object base, uintptr_t addr,
+ def __cinit__(self, object base, uintptr_t addr, int64_t size_bytes,
ArrowBufferType buffer_type, ArrowType buffer_data_type,
Review Comment:
Good call! It's used in the arrayview repr (so I moved it to the ArrayView
where it's more relevant).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
