rok commented on code in PR #37533:
URL: https://github.com/apache/arrow/pull/37533#discussion_r1482264594
##########
cpp/src/arrow/extension/fixed_shape_tensor.cc:
##########
@@ -86,7 +88,7 @@ bool FixedShapeTensorType::ExtensionEquals(const
ExtensionType& other) const {
if (extension_name() != other.extension_name()) {
return false;
}
- const auto& other_ext = static_cast<const FixedShapeTensorType&>(other);
+ const auto& other_ext = dynamic_cast<const FixedShapeTensorType&>(other);
Review Comment:
I forget what the reason was, I vaguely remember it had to do with a change
I later reverted.
Changed to `checked_cast` and it seems to work fine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
