alamb commented on code in PR #9168:
URL: https://github.com/apache/arrow-datafusion/pull/9168#discussion_r1483780699
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -1622,54 +1622,51 @@ impl FromStr for BuiltinScalarFunction {
}
}
-/// Creates a function that returns the return type of a string function given
+/// Creates a function to identify the optimal return type of a string
function given
/// the type of its first argument.
///
/// If the input type is `LargeUtf8` or `LargeBinary` the return type is
/// `$largeUtf8Type`,
///
/// If the input type is `Utf8` or `Binary` the return type is `$utf8Type`,
-macro_rules! make_utf8_to_return_type {
+macro_rules! get_optimal_return_type {
Review Comment:
💯 for the name!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
