amoeba commented on code in PR #40022:
URL: https://github.com/apache/arrow/pull/40022#discussion_r1488585350


##########
.pre-commit-config.yaml:
##########
@@ -36,6 +36,12 @@ repos:
          - dockerfile
         entry: --entrypoint /bin/hadolint hadolint/hadolint:latest -
         exclude: ^dev/.*$
+      - id: sphinx-lint
+        name: Sphinx Lint
+        entry: archery lint --docs
+        language: system

Review Comment:
   Thanks for looking at this.
   
   It does assume archery, yes. Though I'm not sure pre-commit will take care 
of installing/caching required tools. I'll check this though.
   
   I opted for leaning on archery here instead of sphinx-lint directly because 
I felt it's simpler overall if different segments of the developer experience, 
including this one (docs), just require users to install archery rather than 
each segment requiring different tools.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to