miguelpragier commented on code in PR #40090:
URL: https://github.com/apache/arrow/pull/40090#discussion_r1492339460
##########
go/arrow/flight/flightsql/driver/driver.go:
##########
@@ -37,34 +38,50 @@ import (
)
type Rows struct {
- schema *arrow.Schema
- records []arrow.Record
- currentRecord int
- currentRow int
+ schema *arrow.Schema
+ recordChan chan arrow.Record
+ currentRecord arrow.Record
+ currentRecordMux sync.Mutex
+ currentRow uint64
+ initializedChan chan bool
+ streamError error
+}
+
+func newRows() *Rows {
+ return &Rows{
+ recordChan: make(chan arrow.Record, 1),
Review Comment:
thanks, @zeroshade .
I removed the magic number, but kept the buffer size=one.
Do you have suggestions for implementing a dynamic/configurable buffer size?
That could, anyway, happen on a new PR. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
