alamb commented on code in PR #9233: URL: https://github.com/apache/arrow-datafusion/pull/9233#discussion_r1492361852
########## datafusion/sqllogictest/test_files/array.slt: ########## @@ -2603,6 +2603,16 @@ select array_position(arrow_cast(make_array([1, 2, 3], [4, 5, 6], [5, 5, 5], [4, ---- 2 2 +query I +SELECT array_position(arrow_cast([5, 2, 3, 4, 5], 'List(Int32)'), 5) +---- +1 + +query I +SELECT array_position(arrow_cast([5, 2, 3, 4, 5], 'List(Int32)'), 5, 2) Review Comment: Can we please add a few more tests: 1. For `LargeList` 2. Error cases (e.g. for types that are still not compatible like `array_position(arrow_cast([5, 2, 3, 4, 5], 'List(Int32)'), 'foo')` ########## datafusion/sqllogictest/test_files/array.slt: ########## @@ -2603,6 +2603,16 @@ select array_position(arrow_cast(make_array([1, 2, 3], [4, 5, 6], [5, 5, 5], [4, ---- 2 2 +query I +SELECT array_position(arrow_cast([5, 2, 3, 4, 5], 'List(Int32)'), 5) Review Comment: For the record, this test fails on main like this: ``` Error during planning: array_position received incompatible types: '[Int32, Int64]'. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
