vibhatha commented on code in PR #40043:
URL: https://github.com/apache/arrow/pull/40043#discussion_r1495374771
##########
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java:
##########
@@ -476,11 +507,12 @@ private void allocateBytes(final long valueBufferSize,
final int valueCount) {
}
/* allocate offset buffer */
- private void allocateOffsetBuffer(final long size) {
+ private ArrowBuf allocateOffsetBuffer(final long size) {
Review Comment:
@viirya would it be possible to do a simple end-to-end experiment and log
how the refcout varies in the original source vs the new change (at least the
new change) and see what is actually happening. So if we have some call
cancelling a mistake we made in the refcount could be thus reflected and clear
our doubts. Is this a viable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
