paleolimbot commented on code in PR #388:
URL: https://github.com/apache/arrow-nanoarrow/pull/388#discussion_r1496018224
##########
.github/workflows/python-wheels.yaml:
##########
@@ -99,11 +99,8 @@ jobs:
python -m cibuildwheel --output-dir wheelhouse python
env:
CIBW_ARCHS_MACOS: x86_64 arm64
- # Optional (test suite will pass if these are not available)
- # Commenting this for now because not all the tests pass yet (fixes
in another PR)
- # CIBW_BEFORE_TEST: pip install --only-binary ":all:" pyarrow numpy
|| pip install --only-binary ":all:" numpy || true
Review Comment:
Agreed...I'm punting a little bit on pyarrow integration tests until some of
the concepts are more solidified, and I'm not sure the wheel builder is the
best place for that since there isn't a lot of control over the environment
(and it's a pain when the wheel build fails as a result of code that doesn't
live in this repo).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
