westonpace commented on pull request #9095: URL: https://github.com/apache/arrow/pull/9095#issuecomment-771123067
@pitrou I believe this is ready for another review. In addition to fixing your comments: * Removed rvalue version of Future::result() since this is unsafe (future does not own its result exclusively) * Moved the "Transfer" out of the "BackgroundGenerator" so it is explicit as per Zulip discussion * Fixed a bug in the transforming generator. It had a this capture that was not valid because the returned async generator pipeline could be moved around and callbacks might still be referencing this. * The TryAddCallback test would sometimes fail because it is not valid to do std::function<void(const Result<detail::Empty>&)> callback = [&callback_adder_thread_id](...) (the ... can't be assigned to a std::function in that way) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
