JasonLi-cn commented on code in PR #9268:
URL: https://github.com/apache/arrow-datafusion/pull/9268#discussion_r1501743578
##########
Cargo.toml:
##########
@@ -77,6 +77,7 @@ sqlparser = { version = "0.43.0", features = ["visitor"] }
tempfile = "3"
thiserror = "1.0.44"
tokio = { version = "1.36", features = ["macros", "rt", "sync"] }
+unescaper = "0.1.4"
Review Comment:
> That would make sense to me (probably the code belong eventually upstream
in sqlparser-rs but we could start with it in DataFusion)
I think you're right. sqlparser-rs does do some unescape work, but it's not
perfect, and we need to improve it.
https://github.com/sqlparser-rs/sqlparser-rs/blob/1a07c5d67c13c0b635cfe0b3e6b13b5be6cae275/src/tokenizer.rs#L1197-L1258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
