lidavidm commented on a change in pull request #9387:
URL: https://github.com/apache/arrow/pull/9387#discussion_r568690690
##########
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/grpc/AddWritableBuffer.java
##########
@@ -88,11 +87,8 @@
* @param buf The buffer to add.
* @param stream The Candidate OutputStream to add to.
* @return True if added. False if not possible.
- * @throws IOException on error
*/
- public static boolean add(ByteBuf buf, OutputStream stream) throws
IOException {
- buf.readBytes(stream, buf.readableBytes());
Review comment:
Ah, FAST_PATH is an existing flag - it's actually used at the callsite:
https://github.com/apache/arrow/blob/6b85f6eba6d8403dbd549212fbc86f0e8ee192d0/java/flight/flight-core/src/main/java/org/apache/arrow/flight/ArrowMessage.java#L437-L439
But I agree it'd be clearer if we moved FAST_PATH into here and additionally
had it handle the fallback path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
