pitrou commented on code in PR #40230:
URL: https://github.com/apache/arrow/pull/40230#discussion_r1504446102
##########
cpp/src/arrow/util/logging.cc:
##########
@@ -116,7 +116,7 @@ static std::unique_ptr<std::string> log_dir_;
#ifdef ARROW_USE_GLOG
// Glog's severity map.
-static int GetMappedSeverity(ArrowLogLevel severity) {
+static google::LogSeverity GetMappedSeverity(ArrowLogLevel severity) {
Review Comment:
Does this break compatibility with previous versions? If so, perhaps use
`auto` to be more lenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
