SteveLauC commented on code in PR #9377: URL: https://github.com/apache/arrow-datafusion/pull/9377#discussion_r1505454017
########## datafusion/sqllogictest/test_files/scalar.slt: ########## @@ -1874,6 +1874,16 @@ SELECT arrow_typeof(1, 1); statement error Error during planning: No function matches the given name and argument types 'power\(Int64, Int64, Int64\)'. You might need to add explicit type casts.\n\tCandidate functions:\n\tpower\(Int64, Int64\)\n\tpower\(Float64, Float64\) SELECT power(1, 2, 3); +# The following functions need 1 argument +statement error Error during planning: No function matches the given name and argument types 'abs\(\)'. You might need to add explicit type casts.\n\tCandidate functions:\n\tabs\(Any\) +SELECT abs(); + +statement error Error during planning: No function matches the given name and argument types 'acos\(\)'. You might need to add explicit type casts.\n\tCandidate functions:\n\tacos\(Float64/Float32\) +SELECT acos(); + +statement error Error during planning: No function matches the given name and argument types 'isnan\(\)'. You might need to add explicit type casts.\n\tCandidate functions:\n\tisnan\(Float32\)\n\tisnan\(Float64\) +SELECT isnan(); + Review Comment: I have added tests for all the ported math functions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
