alamb commented on issue #8706:
URL:
https://github.com/apache/arrow-datafusion/issues/8706#issuecomment-1968732022
> > A question I have is, replace Replace `impl TryFrom<&Expr> for
protobuf::LogicalExprNode` with a free function may lead a lot of places like
`expr.try_into()` to `serialize_expr(expr, codec)`, would this be OK for the
code base? @thinkharderdev
>
> Yeah I think so. @alamb do you see any issues with that?
I don't see any specific issue and I don't think it would affect users of
the crate much -- I don't think they typically use protobuf encoding directly,
but rather go through the higher level apis like `Expr::to_bytes()`: //! let
expr = col("a").lt(lit(5i32));
//!
//! // Convert it to bytes (for sending over the network, etc.)
//! let bytes = expr.to_bytes()?;
//!
//! // Decode bytes from somewhere (over network, etc.) back to Expr
//! let decoded_expr = Expr::from_bytes(&bytes)?;
//! assert_eq!(expr, decoded_expr);
//! # Ok(())
//! # }
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
