westonpace commented on code in PR #39623:
URL: https://github.com/apache/arrow/pull/39623#discussion_r1505955745
##########
cpp/src/parquet/encryption/internal_file_decryptor.cc:
##########
@@ -139,10 +139,16 @@ std::shared_ptr<Decryptor>
InternalFileDecryptor::GetFooterDecryptor(
// Create both data and metadata decryptors to avoid redundant retrieval of
key
// from the key_retriever.
int key_len = static_cast<int>(footer_key.size());
- auto aes_metadata_decryptor = encryption::AesDecryptor::Make(
- algorithm_, key_len, /*metadata=*/true, &all_decryptors_);
- auto aes_data_decryptor = encryption::AesDecryptor::Make(
- algorithm_, key_len, /*metadata=*/false, &all_decryptors_);
+ std::shared_ptr<encryption::AesDecryptor> aes_metadata_decryptor;
+ std::shared_ptr<encryption::AesDecryptor> aes_data_decryptor;
+
+ {
+ std::lock_guard<std::mutex> lock(mutex_);
Review Comment:
Should we also be locking on `mutex_` in `WipeOutDecryptionKeys`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
