pitrou commented on PR #40271:
URL: https://github.com/apache/arrow/pull/40271#issuecomment-1969234095
After running the benchmarks locally, it seems that this is triggering a
bunch of regressions when writing a StringArray to CSV:
```
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Regressions: (8)
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
benchmark baseline contender change %
counters
WriteCsvStringNoQuote/50 692.326 MiB/sec 621.875 MiB/sec -10.176
{'family_index': 1, 'per_family_instance_index': 3, 'run_name':
'WriteCsvStringNoQuote/50', 'repetitions': 1, 'repetition_index': 0, 'threads':
1, 'iterations': 2217, 'null_percent': 50.0}
WriteCsvStringRejectQuote/50 704.688 MiB/sec 625.617 MiB/sec -11.221
{'family_index': 3, 'per_family_instance_index': 3, 'run_name':
'WriteCsvStringRejectQuote/50', 'repetitions': 1, 'repetition_index': 0,
'threads': 1, 'iterations': 2418, 'null_percent': 50.0}
WriteCsvStringNoQuote/10 1.478 GiB/sec 1.250 GiB/sec -15.420
{'family_index': 1, 'per_family_instance_index': 2, 'run_name':
'WriteCsvStringNoQuote/10', 'repetitions': 1, 'repetition_index': 0, 'threads':
1, 'iterations': 2840, 'null_percent': 10.0}
WriteCsvStringNoQuote/0 1.976 GiB/sec 1.652 GiB/sec -16.403
{'family_index': 1, 'per_family_instance_index': 0, 'run_name':
'WriteCsvStringNoQuote/0', 'repetitions': 1, 'repetition_index': 0, 'threads':
1, 'iterations': 3384, 'null_percent': 0.0}
WriteCsvStringNoQuote/1 1.857 GiB/sec 1.540 GiB/sec -17.098
{'family_index': 1, 'per_family_instance_index': 1, 'run_name':
'WriteCsvStringNoQuote/1', 'repetitions': 1, 'repetition_index': 0, 'threads':
1, 'iterations': 3184, 'null_percent': 1.0}
WriteCsvStringRejectQuote/10 1.829 GiB/sec 1.465 GiB/sec -19.942
{'family_index': 3, 'per_family_instance_index': 2, 'run_name':
'WriteCsvStringRejectQuote/10', 'repetitions': 1, 'repetition_index': 0,
'threads': 1, 'iterations': 3843, 'null_percent': 10.0}
WriteCsvStringRejectQuote/0 2.878 GiB/sec 2.300 GiB/sec -20.086
{'family_index': 3, 'per_family_instance_index': 0, 'run_name':
'WriteCsvStringRejectQuote/0', 'repetitions': 1, 'repetition_index': 0,
'threads': 1, 'iterations': 5652, 'null_percent': 0.0}
WriteCsvStringRejectQuote/1 2.660 GiB/sec 1.966 GiB/sec -26.074
{'family_index': 3, 'per_family_instance_index': 1, 'run_name':
'WriteCsvStringRejectQuote/1', 'repetitions': 1, 'repetition_index': 0,
'threads': 1, 'iterations': 4869, 'null_percent': 1.0}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
