AlenkaF commented on code in PR #39825:
URL: https://github.com/apache/arrow/pull/39825#discussion_r1507504426
##########
python/pyarrow/tests/parquet/test_dataset.py:
##########
@@ -1009,15 +991,24 @@ def _test_write_to_dataset_no_partitions(base_path,
output_table = pa.Table.from_pandas(output_df)
if filesystem is None:
- filesystem = LocalFileSystem._get_instance()
+ filesystem = LocalFileSystem()
# Without partitions, append files to root_path
n = 5
for i in range(n):
pq.write_to_dataset(output_table, base_path,
filesystem=filesystem)
- output_files = [file for file in filesystem.ls(str(base_path))
- if file.endswith(".parquet")]
+
+ try:
+ output_files = [file for file in filesystem.ls(str(base_path))
Review Comment:
Ah sorry, in the case of 'S3FileSystem' the try is needed. Or I can do the
same as in `_generate_partition_directories` and wrap it into pyarrow
Filesystem in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
