asimsedhain commented on PR #9015: URL: https://github.com/apache/arrow-datafusion/pull/9015#issuecomment-1972667216
> Thanks @asimsedhain -- this looks great. My only concern is about using `saturating_sub` rather than `checked_sub` as it could potentially mask bugs, but otherwise I think this PR looks good to go. > > Sorry again for the delay in review True, I didn't consider that it could mask potential bugs. Replaced it with checked add. Thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
