pitrou commented on code in PR #39067:
URL: https://github.com/apache/arrow/pull/39067#discussion_r1516484542


##########
cpp/src/arrow/util/visibility.h:
##########
@@ -80,4 +82,6 @@
 #define ARROW_FRIEND_EXPORT
 #define ARROW_TEMPLATE_EXPORT
 
+#define ARROW_FORCE_EXPORT [[gnu::visibility("default")]]

Review Comment:
   Hmm, ok, perhaps it's best to add a comment explaining what this macro is 
for, then (compared to ARROW_EXPORT).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to