alamb commented on code in PR #9537:
URL: https://github.com/apache/arrow-datafusion/pull/9537#discussion_r1520416444
##########
datafusion/core/tests/optimizer_integration.rs:
##########
@@ -342,7 +343,12 @@ fn test_sql(sql: &str) -> Result<LogicalPlan> {
let statement = &ast[0];
// create a logical query plan
- let context_provider = MyContextProvider::default();
+ let now_udf = datetime::functions()
Review Comment:
How much of the optimizer integration test do you think needs Udfs? I am
wondering maybe we could just port the tests case for `now()` into
core/tests/sql_integration` or something and eave the rest of the
optimizer_integration test in the optimizer crate?
The reason it might be good to leave the optimzer tests in the optimizer
crate are
1. Easier to run `cargo test -p datafusion_optimizer` and run all the
relevant tests
2. Ensure that we could still use `datafusion_optimizer` without the
function definitions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
