bkietz commented on code in PR #40396:
URL: https://github.com/apache/arrow/pull/40396#discussion_r1521903128
##########
cpp/src/arrow/compute/expression_test.cc:
##########
@@ -895,8 +895,13 @@ TEST(Expression, ExecuteCallWithNoArguments) {
Review Comment:
Please rename this test case to `TEST(Expression,
SimplifyImpureFunctionCall)`
Also, please add an impure function which takes arguments so that we can
verify that arguments still get simplified:
```c++
auto pure_expr = call("add", {field_ref("i32"), literal(3)});
Simplify{
call("my_seeded_random", {pure_expr})
}
.WithGuarantee(equal(field_ref("i32"), literal(1))
.Expect(call("my_seeded_random", {literal(4)}));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
