alamb commented on code in PR #9601:
URL: https://github.com/apache/arrow-datafusion/pull/9601#discussion_r1523677491
##########
datafusion/functions/benches/to_char.rs:
##########
@@ -42,8 +38,8 @@ fn random_date_in_range(
start_date + TimeDelta::try_days(random_days).unwrap()
}
-fn data(rng: &mut ThreadRng) -> Date32Array {
- let mut data: Vec<i32> = vec![];
+fn data(rng: &mut ThreadRng) -> Vec<Expr> {
Review Comment:
doesn't this change the meaning of the benchmark from testing to_char on a
single array to testing to_char on a single row with 1000's of arguments?
Like `to_date(v1, v2, v3, .....)`
instead of `to_date(arr)` ?
Is that intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
