kou commented on code in PR #40022:
URL: https://github.com/apache/arrow/pull/40022#discussion_r1527933180
##########
.pre-commit-config.yaml:
##########
@@ -52,3 +53,9 @@ repos:
hooks:
- id: cython-lint
args: [--no-pycodestyle]
+ - repo: https://github.com/sphinx-contrib/sphinx-lint
+ rev: v0.9.1
+ hooks:
+ - id: sphinx-lint
+ files: ^docs/
+ args: ['--disable', 'all', '--enable',
'trailing-whitespace,missing-final-newline', 'docs']
Review Comment:
Can we remove `docs` from this list? (I think that duplicated logs are
caused by this.)
Could you use multi-lines array style instead of one-line array style? It
seems that we need to specify many command line options later. One-line array
style will be difficult to understand.
```suggestion
args:
- --disable
- all
- --enable
- trailing-whitespace,missing-final-newline
```
##########
dev/archery/archery/cli.py:
##########
@@ -284,9 +285,10 @@ def decorate_lint_command(cmd):
help="Run IWYU on all C++ files if enabled")
@click.option("-a", "--all", is_flag=True, default=False,
help="Enable all checks.")
+@click.argument("path", required=False)
Review Comment:
Why do we need this?
Do we need to use custom path for `docs/`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
